Re: patch usb-iowarrior.patch added to gregkh-2.6 tree

Am Donnerstag, 15. Februar 2007 19:35 schrieb Greg KH:
> On Thu, Feb 15, 2007 at 01:51:31PM +0100, Oliver Neukum wrote:
> > Am Donnerstag, 15. Februar 2007 00:31 schrieb [email protected]:
> > > +??????????????dev = (struct iowarrior *)file->private_data;
> > > +
> > > +??????????????/* verify that the device wasn't unplugged */
> > > +??????????????if (dev == NULL || !dev->present) {
> > > +??????????????????????????????retval = -ENODEV;
> > > +??????????????????????????????goto exit;
> > > +??????????????}
> > 
> > This needs the lock to be taken. You've a race condition that allows
> > URBs to be submitted for an interface that somebody else may have
> > claimed.
> 
> Which lock?  The disconnect_sem one?

mutex_lock(&dev->mutex);
The same that is already taken in the ioctl handler.

	Regards
		Oliver

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel