Re: [PATCH] Davicom DM9601 usbnet driver
David Brownell <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Friday 16 February 2007 8:03 am, Peter Korsgaard wrote: > This patch adds a driver for the Davicom DM9601 USB 1.1 10/100Mbps > ethernet adaptor using the usbnet framework. > > See http://www.davicom.com.tw/eng/products/dm9601.htm for details. > > Signed-off-by: Peter Korsgaard <[email protected]> Looks nice to me! Thanks; I always like to see new drivers using that framework. My only comment is that the rx_fixup should probably insist that the packets meet Ethernet standards for length; this code looks like it'll accept packets smaller than ETH_ZLEN. Other than that: Signed-off-by: David Brownell <[email protected]> ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel