[PATCH 0/3] ftdi_sio: fix oops on access to the latency_timer
Jim Radford <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Hi Greg, This series of patches fixes a NULL pointer deference that occurs when accessing ftdi_sio driver's sysfs latency_timer. The latency_timer is currently created on the usb_device. I couldn't figure out how to easily "get" from the usb_device to the usb_serial_port in the callback, and it seems neither could whomever broke it in the first place. This worked in 2.6.18 and was broken in 2.6.19. I moved the latency_timer to the usb_serial_port, which seems to me like a more natural place for it. In order to do that I had to move the device_register() before the ->attach() in usb-serial. I'm not sure what the implications of that are, but it works for me. After that I could fix up the show/store callbacks. These patches are against Linus' latest git tree (~ 2.6.21-rc1). -Jim ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel