Re: [RFC] [PATCH 0/5]: Composite Devices Support
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 22 Feb 2007, Felipe Balbi wrote: > When I wrote "attributions" I meant: > struct usb_gadget *gadget = cdev->current_func->gadget; > > This I already turned up into: > struct usb_gadget *gadget = get_composite_gadget(cdev); > > And other instructions like this one... The one thing I didn't like about your changes was all the #ifdef lines added to the function definitions. Perhaps you can come up with some typedefs and inline routines (whose definitions would depend on whether or not the composite-gadget option was enabled) to make the code look simple again. Alan Stern ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel