Re: [PATCH] USB Elan FTDI: check for workqueue creation v2
Pete Zaitcev <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.kernel |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On Sat, 24 Feb 2007 10:41:15 +0300, Cyrill Gorcunov <[email protected]> wrote: > Thanks a lot for comments and Ack the patch please. Cyrill, I forgot to mention a couple of points, sorry. > printk(KERN_INFO "driver %s built at %s on %s\n", ftdi_elan_driver.name, > - __TIME__, __DATE__); > + __TIME__, __DATE__); Is this really necessary? > respond_queue = create_singlethread_workqueue("ftdi-respond-engine"); > + if (!respond_queue) > + goto err3; This is good, but... > result = usb_register(&ftdi_elan_driver); > if (result) > printk(KERN_ERR "usb_register failed. Error number %d\n", > - result); > + result); > return result; What does happen if usb_register fails? Since you fixed the create_singlethread_workqueue, why not this too? -- Pete cc: to Tony@ELAN and linux-usb-devel ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel