Re: USB device losing power

Hi,

On 2/14/07, Alan Stern <[email protected]> wrote:
> On Tue, 13 Feb 2007, Guilherme Salgado wrote:
[...]
> >  so I did the
> > changes manually and used upper case characters on the message passed
> > to dev_info(), to make sure the new module was loaded correctly, and I
> > seem to have got the same thing on syslog:
>
> There were only two differences between the patch you typed in and the one
> I sent.  One difference was the capital letters in the log message.  The
> other difference is here:
>
> > > +                       if (!(inw(port_addr) &
> > > +                                       (USBPORTSC_SUSP | USBPORTSC_RD)))
>
> > +                       if (!(inw(port_addr) &
> > +                                       (USBPORTSC_RD | USBPORTSC_RD)))
>
> You typed USBPORTSC_RD twice instead of USBPORTSC_SUSP.  Unfortunately,
> that was the whole point of the new patch.  So the patch you tested was
> essentially the same as the original one.
>

Oooops. I've been trying to teach my eyes to catch these sorts of
things for a while, but it's not easy. Thanks for spotting that.

I had some problems with the 2.6.20 kernel on my distribution and so I
wasn't able to test the patch for some time. Fortunately, everything
is working now and I'm running 2.6.20 with the patch you provided, and
the "can't resume" problem is gone. I can easily reproduce it with the
unpatched module loaded, but it never occurred when I had the patched
module loaded.

Does this patch provide the proper fix for the issue or was it just a
workaround or something like that? In case of the former, can I expect
it to go to mainline soon?

Thanks a lot,
Guilherme

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel