Re: false positive -ENOSPC in ohci-q

On Monday 26 February 2007 7:11 am, Andrea Arcangeli wrote:
> Hello,
> 
> until I applied the below patch I couldn't use the usb camera at the
> same time of the usb modem (both usb1 devices). The camera returned
> -ENOSPC. Now they both work fine at the same time (camera managed by
> zoneminder and running all the time and the modem giving me the
> internet link, both without any apparent problem).

NAK unless you can demonstrate a bug in the logic you disabled.
Looks more like your config is one that's disallowed.


> Please make sure the below broken code is removed (or fixed) from
> future releases. I'm available for testing fixed version of the
> code. It seems Greg's usb tree is different so perhaps this was fixed
> already but sure it wasn't fixed in mainline yet, so I'm sending this
> reminder just in case.

Under what circumstances could this patch ever be *correct* though?

- Dave


> 
> Thanks!
> 
> diff -r a860286d4b60 drivers/usb/host/ohci-q.c
> --- a/drivers/usb/host/ohci-q.c	Fri Feb 16 20:15:14 2007 +0000
> +++ b/drivers/usb/host/ohci-q.c	Sun Feb 25 07:07:46 2007 +0100
> @@ -107,6 +107,7 @@ static int balance (struct ohci_hcd *ohc
>  	 */
>  	for (i = 0; i < interval ; i++) {
>  		if (branch < 0 || ohci->load [branch] > ohci->load [i]) {
> +#if 0
>  			int	j;
>  
>  			/* usb 1.1 says 90% of one frame */
> @@ -116,6 +117,7 @@ static int balance (struct ohci_hcd *ohc
>  			}
>  			if (j < NUM_INTS)
>  				continue;
> +#endif
>  			branch = i;
>  		}
>  	}
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> [email protected]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel