Re: usbmon: Add class for the binary API [second try]

On Tue, Feb 27, 2007 at 01:44:42PM +0100, Paolo Abeni wrote:
> This patch adds a class which allows for an easier integration with
> udev.
> 
> Signed-off-by: Paolo Abeni <[email protected]>
> Signed-off-by: Pete Zaitcev <[email protected]>
> 
> --- 
> 
> I just changed the struct device creation, using the ubus->controller for
> the parent device, as suggested by Greg. Otherwise, is the latest
> version posted by Pete.

Huh?  No, this is the same as before:

> +int mon_bin_add(struct mon_bus *mbus, const struct usb_bus *ubus)
> +{
> +	struct device * dev;
> +	unsigned minor = ubus->busnum;
> +
> +	if (minor >= MON_BIN_MAX_MINOR)
> +		return 0;
> +
> +	dev = device_create(mon_bin_class, 0, 
> +		MKDEV(MAJOR(mon_bin_dev0), minor), "usbmon%d", 
> +		minor);

You are still not passing in a parent for the device here.

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel