Re: [PATCH] generic gpio: add default level to gpio_direction_output

On Thursday 01 March 2007 6:32 am, Milan Svoboda wrote:
> This patch adds second parameter to gpio_direction_output function.
> This allows users to specify default output level.
> 
> Patch covers pxa and ixp4xx plus driver for pxa2xx_udc.
> 
> Patch is agains 2.6.21-rc1
> 
> What do you think about this attempt?

I'd avoid defining new GPIO_DIRECTION_OUT_{LOW,HIGH} symbols, and
stick to the convention used in gpio_set_value().  If there were
to be a new symbol, it should work with both functions; so that
long "_DIRECTION" would be unwise.

Other than that, it's exactly what I'd want to see.  Andrew, Haavard;
any comments?  Only PXA/IXP4XX and AT91/AVR32 need paired changes, so
if there are no problems with those platforms, the rest can almost go
independently.

This will toss another minor monkey wrench in the path of the GPIO LEDS
driver, but that's workable.  If we get this sorted for RC3 then I can't
see too many other glitches coming up.

- Dave


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel