Re: usbmon: tentative implementation for 'bus0' interface

On Thu, 2007-03-01 at 19:48 -0800, Pete Zaitcev wrote:
> > @@ -441,7 +441,7 @@ static void mon_bin_event(struct mon_rea
> >  	/* We use the fact that usb_pipein() returns 0x80 */
> >  	ep->epnum = usb_pipeendpoint(urb->pipe) | usb_pipein(urb->pipe);
> >  	ep->devnum = usb_pipedevice(urb->pipe);
> > -	ep->busnum = rp->r.m_bus->u_bus->busnum;
> > +	ep->busnum = urb->dev->bus->busnum;
> ........
> > @@ -18,6 +18,7 @@ struct mon_bus {
> >  	struct list_head bus_link;
> >  	spinlock_t lock;
> >  	struct usb_bus *u_bus;
> > +	int busnum;
> 
> These two ideas are not completely in agreement with each other.
> I think I'll take the second one, a local copy of the bus number.

My idea was to use the first one. I leaved the second by mistake. The
issue for the second solution is that don't work for bus0: it give
busnum == 0 that is meaningless. 

Thanks for the review and best regards,

Paolo


 
 
 --
 Email.it, the professional e-mail, gratis per te: http://www.email.it/f
 
 Sponsor:
 Scopri RIS il sistema di ricarica infinita. Meglio delle cartucce, meglio degli inchiostri, economico, facile da installare e da utilizzare, solo su refill.it
 Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=5191&d=2-3

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel