Re: HID blacklisting of all Code Mercenaries IOWarrior devices (resubmit)
Jiri Kosina <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Fri, 2 Mar 2007, Robert Marquardt wrote: > Put all Code Mercenaries (VID 0x07c0) IOWarriors (PIDs 0x1500 to 0x15ff) > on the HID blacklist. The range of PIDs has been reserved for > IOWarriors. Only 5 PIDs are really used yet. > The diff is from drivers/usb/input/hid-core.c of 2.6.21-rc2 > Signed-off-by: Robert Marquardt <[email protected]> Thanks, we are nearly there. Just a two things before I can apply it please - could you please format the patch in the form described in Documentation/SubmittingPatches, first chapter? Namely if it would be possible to be against the whole tree, so that it is applicable using standard scm tools from the toplevel of the source tree (i.e. the diff should contain the full path drivers/hid/hid-core.c, not only hid-core.c). - the following line in your patch: le16_to_cpu(dev->descriptor.idProduct) <= USB_DEVICE_ID_CODEMERCS_IOW_LAST) seems to have broken indentation (space at the beginning of the line). Could you please fix it? Thanks a lot, -- Jiri Kosina ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel