Re: 2.6.21-rc2-mm1: drivers/usb/host/ohci-ssb.c doesn't compile

On Monday 05 March 2007 11:49, Michael Buesch wrote:
> On Monday 05 March 2007 02:47, Adrian Bunk wrote:
> > On Fri, Mar 02, 2007 at 03:00:26AM -0800, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.20-mm2:
> > >...
> > >  git-wireless.patch
> > >...
> > >  git trees
> > >...
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      drivers/usb/host/ohci-hcd.o
> > In file included from 
> > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-hcd.c:931:
> > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: request for member 'hcd_priv_size' in something not a structure or union
> 
> Seems like there was a comma missing.
> There also seems to be some Kconfig problem. will fix that.
> 
> > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:47: error: 'ssb_ohci_device' undeclared here (not in a function)
> > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:52: error: 'ssb_ohci_reset' undeclared here (not in a function)
> > /home/bunk/linux/kernel-2.6/linux-2.6.21-rc2-mm1/drivers/usb/host/ohci-ssb.c:53: error: 'ssb_ohci_start' undeclared here (not in a function)
> > ...
> > make[4]: *** [drivers/usb/host/ohci-hcd.o] Error 1
> > 
> > <--  snip  -->

Actually, it seems like I will run into other kinds of nasty problems
due to stupid design of the HCD code. The OHCI code #includes
the various drivers, which have a module_init each. So if you
compile PCI and SSB support, you have two module_init for one
OHCI module. Not sure how to fix this. Any idea?

-- 
Greetings Michael.