Re: usbmon: tentative implementation for 'bus0' interface
Pete Zaitcev <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On Wed, 07 Mar 2007 08:47:37 +0100, Paolo Abeni <[email protected]> wrote: > > #2 - The setting and testing of the monitoring flag was completely > > ignored by the patch. > > Am I missing something or the 'monitored' flag is used to double check > the usbmon structures consistence ?!? In an ideal (bugless) world could > this flag be removed ?!? (I'm not asking to do that!!! it's just > informative) The flag is there to prevent us from calling functions and taking locks. It is only an optimization (arguably, even a premature one). Always when such techniques are used, there's ugliness, mb(), and synchronize_irq(). The alternative is to take spinlocks. Anyway, please look at the patch which I sent and see if you find any races, especially on rmmod and reader exits. > > This is not ready to go to Greg yet. > > What about the device patch ? Should we send differential patch against > it or just ignore? I do not understand, sorry. If you are talking about the patch which adds a device in a class, I think that is already in. -- Pete ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel