Re: [patch 8/8] Omap_udc Modification

On Monday 19 March 2007 8:10 am, Felipe Balbi wrote:
> 	This patch adds some endpoints into omap_udc fifo_mode
> 	for the three already modified gadget to work together

However, it's legit for code to hard-wire knowledge that
a given fifo_mode, a given endpoint exists ... so what you
should do is really **ADD** the new bulk endpoints, rather than
changing two existing ones from ISO to bulk and then adding
some ISO endpoints to make up for that.


> Signed-off-by: Felipe Balbi <[email protected]>
> Signed-off-by: Ragner Magalhes <[email protected]>
> ---
> 
> Index: linux-2.6/drivers/usb/gadget/omap_udc.c
> ===================================================================
> --- linux-2.6.orig/drivers/usb/gadget/omap_udc.c
> +++ linux-2.6/drivers/usb/gadget/omap_udc.c
> @@ -2760,5 +2760,9 @@ omap_udc_setup(struct platform_device *o
>  
> -		OMAP_ISO_EP("ep7in",   USB_DIR_IN  | 7, 256);
> -		OMAP_ISO_EP("ep8out",  USB_DIR_OUT | 8, 256);
> -		OMAP_INT_EP("ep9in",   USB_DIR_IN  | 9, 16);
> +		OMAP_BULK_EP("ep7in",   USB_DIR_IN  | 7);
> +		OMAP_BULK_EP("ep8out",  USB_DIR_OUT | 8);
> +		OMAP_INT_EP("ep9in",    USB_DIR_IN  | 9, 16);
> +
> +		OMAP_ISO_EP("ep10in",   USB_DIR_IN  | 10, 256);
> +		OMAP_ISO_EP("ep11out",  USB_DIR_OUT | 11, 256);
> +		OMAP_INT_EP("ep12in",   USB_DIR_IN  | 12, 16);
>  		break;
> 
> --
> Best Regards,
> 
> Felipe Balbi
> [email protected]
> 
> Nokia Institute of Technology - INdT
> Kernel Developers Team
> 
> +55 92 2126 1003
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> [email protected]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel