Re: [PATCH]option close race
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Novell |
| Message-ID | <[email protected]> |
Am Dienstag, 20. März 2007 14:11 schrieb [email protected]: > Hi, > > Oliver Neukum: > > the option driver does not directly use usb_kill_urb(). It uses a wrapper. > > This wrapper means that callbacks which are running are not killed during > > close, resubmitting and illicitly pushing data into the tty layer. > > The whole purpose of usb_kill_urb() is subverted. The wrapper must be > > removed. > > > Umm, I don't recall off-hand whether urb can ever be NULL, e.g. due to > allocation problems. Did you verify that it cannot? usb_kill_urb() may be called with NULL. It turns into a nop. Regards Oliver ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel