Re: [PATCH 2.6.20 1/1] usb/input updated aiptek tablet driver
Pete Zaitcev <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On Sat, 24 Mar 2007 17:23:55 +0100, René van Paassen <[email protected]> wrote: > I will change the del_timer to del_timer_sync, to remove the race where > the timer´s activity is running while the timer is being removed. > > Does that sound reasonable? Yes, it's a good idea, however this is not quite what I was concerned about. For a timer, it's possible to run on one CPU while a URB callback is being delivered on another CPU. Even if Dmitry does everything right and provides a perfect exclusion inside input_report(), you still may end with input events interleaving without some kind of exclusion in the driver. This is why I asked if aiptek can call input_report_abs() with interrupts closed (which happens if you bracket them with spin_lock_irqsave() in your timer routine). -- Pete ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel