Re: [PATCH]correctly handling failed opens in usb-serial
Alan Cox <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 29 Mar 2007 14:29:07 -0700 Greg KH <[email protected]> wrote: > On Thu, Mar 29, 2007 at 10:15:00AM +0200, Oliver Neukum wrote: > > Hi, > > > > as recently discussed on lkml the tty layer does call close() if > > an open() fails. Usb-serial does not handle this correctly. It does > > handle the first open() failing by checking the open count, but if > > a second open() fails, the close() will free the resources associated > > with the first open. > > Why can't we just fix the tty layer instead? Feel free, it just needs all existing serial drivers to be audited for dependancies on the old behaviour and corrected. Painful, tedious work but possibly worth doing ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel