Re: [PATCH]correctly handling failed opens in usb-serial

On Fri, Mar 30, 2007 at 08:13:20AM +0200, Oliver Neukum wrote:
> Am Donnerstag, 29. M?rz 2007 23:29 schrieb Greg KH:
> > On Thu, Mar 29, 2007 at 10:15:00AM +0200, Oliver Neukum wrote:
> > > Hi,
> > > 
> > > as recently discussed on lkml the tty layer does call close() if
> > > an open() fails. Usb-serial does not handle this correctly. It does
> > > handle the first open() failing by checking the open count, but if
> > > a second open() fails, the close() will free the resources associated
> > > with the first open.
> > 
> > Why can't we just fix the tty layer instead?
> 
> Do you want to audit every other serial driver to make sure cleanup isn't
> deferred to close?

Well, to fix such a broken thing, yes, I do.

Hey, I have a 12 hour plane ride coming up, I wonder how long my laptop
battery will last :)

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel