Re: defected usb-serial config. fix (Re: [patch 2.6.21-rc5] usb-serial, ti_usb: fix usb configuration changing)

On Mon, Apr 02, 2007 at 05:27:16PM +0200, Oliver Neukum wrote:
> Am Montag, 2. April 2007 13:25 schrieb Al Borchers:
> > Oleg --
> > 
> > Quoting Oleg Verych <[email protected]>:
> > > OK, then i must recheck, why it works for me. Maybe it's just another
> > > sysfs crap, because i tested on rc5 without any of it enabled.
> > 
> > You will only see the problem if you have more than one usb serial
> > device.  Plug in the first device, then plug in a TI 3410 device.
> > They will both try to use ttyUSB0--unplug them and you will see an
> > oops.
> > 
> > The problem is not in your patch; the problem is in usb-serial,
> > as I described.
> 
> Does this help?

Would you like to justify, why it was changed, and now (safely?)
reverted please?

> 	Regards
> 		Oliver
> Signed-off-by: Oliver Neukum <[email protected]>
> --------
> --- linux-2.6.21-rc5/drivers/usb/serial/usb-serial.c.alt	2007-04-02 17:19:15.000000000 +0200
> +++ linux-2.6.21-rc5/drivers/usb/serial/usb-serial.c	2007-04-02 17:22:20.000000000 +0200
> @@ -969,17 +969,24 @@

Would you like to add '-p' option to 'diff', to see a function name.

>  	} else if (num_interrupt_out) {
>  		dbg("the device claims to support interrupt out transfers, but write_int_callback is not defined");
>  	}
> -	
> -	/* if this device type has an attach function, call it */
> +
> +	if (get_free_serial (serial, num_ports, &minor) == NULL) {
                           ^ this isn't accepted coding style, AFAIK.
____

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel