Re: urbs are REFERENCE COUNTED!!! [was Re: [PATCH]generic usb serial driver]

On Mon, Apr 02, 2007 at 08:03:27AM -0700, Pete Zaitcev wrote:
> On Mon, 2 Apr 2007 01:52:22 -0700, Greg KH <[email protected]> wrote:
> 
> > Why would you not want it in every driver?  As Oliver is finding out, a
> > lot of these "simple" drivers have races all due to their use of a
> > pre-allocated urb.  For what kind of situation would you feel this would
> > not work?
> 
> We need some kind of sample code which works. I had to patch airprime
> because your implementation of the read path was erroneous. The write
> path was ok, presumably because you took it out of visor where it was
> tested before. So perhaps we want to start with some driver and declare
> it "ideal", then steal code from it. The usblp would be a good choice,
> but we had so many regressions over time in it... It seems to be
> trickier than it looks. If you want, I can try that later, since I have
> to answer Oliver's challenge of mb()-less code anyway.

Yes, after writing the above, I spent the day with Oliver talking all
about these issues.  And I agree that we need a good example driver,
I'll take a look at getting the usb-skeleton driver working properly for
all of this.

thanks,

greg k-h

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel