Re: Machine check in ohci_hub_status_data (powerpc)

> The comparable routine in uhci-hcd includes this code:
> 
> 	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags) || uhci->dead)
> 		goto done;
> 
> and likewise, ehci_hub_status_data() includes this:
> 
> 	if (!HC_IS_RUNNING(hcd->state))
> 		return 0;
> 
> Something similar needs to be added in ohci-hub.c.  Does the patch below 
> fix your problem?

Looks indeed like I missed that bit when I added the HW_ACCESSIBLE flag
thingy. Your patch looks good, Johannes, does it help ?

Cheers,
Ben.

> 
> 
> Index: usb-2.6/drivers/usb/host/ohci-hub.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/ohci-hub.c
> +++ usb-2.6/drivers/usb/host/ohci-hub.c
> @@ -417,6 +417,8 @@ ohci_hub_status_data (struct usb_hcd *hc
>  	unsigned long	flags;
>  
>  	spin_lock_irqsave (&ohci->lock, flags);
> +	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags))
> +		goto done;
>  
>  	/* undocumented erratum seen on at least rev D */
>  	if ((ohci->flags & OHCI_QUIRK_AMD756)


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel