Re: Machine check in ohci_hub_status_data (powerpc)

On Wed, 2007-04-18 at 11:42 -0400, Alan Stern wrote:

> Something similar needs to be added in ohci-hub.c.  Does the patch below 
> fix your problem?

I stuck in a dump_stack() right before the spin_lock_irqsave too to make
sure I was hitting the code path at the same spot I analysed at earlier,
and I did hit the code path and had no problems, so yes, it fixes it.

johannes

> --- usb-2.6.orig/drivers/usb/host/ohci-hub.c
> +++ usb-2.6/drivers/usb/host/ohci-hub.c
> @@ -417,6 +417,8 @@ ohci_hub_status_data (struct usb_hcd *hc
>  	unsigned long	flags;
>  
>  	spin_lock_irqsave (&ohci->lock, flags);
> +	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags))
> +		goto done;
>  
>  	/* undocumented erratum seen on at least rev D */
>  	if ((ohci->flags & OHCI_QUIRK_AMD756)

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Comment: Johannes Berg (powerbook)

iD8DBQBGKNrY/ETPhpq3jKURAtlpAJ9afvXlo4J+pohysoa336UNRCTf4gCfQtnR
ZRlZqBhKzyZP6FsioyVqAnI=
=ZBA2
-----END PGP SIGNATURE-----