Re: [resend PATCH v2 1/3]USB: add Freescale high-speed USB SOC device controller driver

> -----Original Message-----
> From: Timur Tabi [mailto:[email protected]]
> Sent: Friday, April 27, 2007 5:26 AM
> To: Li Yang-r58472
> Cc: [email protected]
> Subject: Re: [resend PATCH v2 1/3]USB: add Freescale high-speed USB
SOC device
> controller driver
> 
> Leo,
> 
> > +static void fsl_free_buffer(struct usb_ep *_ep, void *buf,
> > +		dma_addr_t dma, unsigned bytes)
> > +{
> > +	struct fsl_ep *ep;
> > +
> > +	if (!_ep)
> > +		return NULL;
> 
> This won't compile.  A void function can't return anything, including
NULL.
> 
> [snip]

A warning actually, I was planning to fix this after the initial version
of this driver is integrated.

> 
> > +static struct fsl_udc *__init struct_udc_setup(struct
platform_device *pdev)
> > +{
> > +	struct fsl_udc *udc;
> > +	struct fsl_usb2_platform_data *pdata;
> > +	size_t size;
> > +
> > +	udc = kzalloc(sizeof(struct fsl_udc), GFP_KERNEL);
> > +	if (udc == NULL) {
> > +		ERR("malloc udc failed\n");
> > +		return NULL;
> > +	}
> > +
> > +	pdata = pdev->dev.platform_data;
> > +	udc->phy_mode = pdata->phy_mode;
> > +	/* max_ep_nr is bidirectional ep number, max_ep doubles the
number */
> > +	udc->max_ep = pdata->max_ep_nr * 2;
> 
> I get this error when I compile:
> 
> drivers/usb/gadget/fsl_usb2_udc.c: In function 'struct_udc_setup':
> drivers/usb/gadget/fsl_usb2_udc.c:2205: error: 'struct
fsl_usb2_platform_data' h
> as no
> member named 'max_ep_nr'

This driver requires a patch to PowerPC code as well which hasn't been
integrated, the problem will be solved in 2.6.22 early RC.

- Leo

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel