Re: usbmon: Add class for binary interface

On Thu, Apr 12, 2007 at 11:16:47PM -0700, Pete Zaitcev wrote:
> Add a class which allows for an easier integration with udev.
> 
> Signed-off-by: Pete Zaitcev <[email protected]>
> 
> ---
> 
> Greg:
> 
> This patch falls back onto device_create with NULL parent, because
> of bus0. Obviously, no real USB bus corresponds to it. I thought it
> not as pretty to have all the real class devices attached,
> but not the pseudo one. So I'm resubmitting the patch the way it was
> before you asked us to correct it.
> 
> I can change it into something like:
> 
> 	dev = device_create(mon_bin_class, ubus? ubus->controller: NULL,
> 			MKDEV(MAJOR(mon_bin_dev0), minor), "usbmon%d", minor);
> 
> Seems a bit wrong to me, but please let me know if you think otherwise,
> I'll resend. As far as I can tell, Paolo doesn't care either way.

Please change it to be this way, as we do want to show the heirachy
whenever possible.  For "bus 0" I agree that we don't have to have a
parent, as that doesn't make sense.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel