Re: [PATCH 36/78] USB: add power/level sysfs attribute

Am Freitag, 27. April 2007 20:55 schrieb Greg Kroah-Hartman:
> +       } else if (len == sizeof suspend_string - 1 &&
> +                       strncmp(buf, suspend_string, len) == 0) {
> +               udev->autosuspend_disabled = 0;
> +               udev->autoresume_disabled = 1;
> +               rc = usb_external_suspend_device(udev, PMSG_SUSPEND);
> +

Hi,

this introduces the possibility of a suspension while user space is
doing IO. Now I know that I was in favor of doing this. But on second
thought, it is problematic. It seems to me we should have a way
to generically block io. This is not solvable in the suspend method,
as we can't tell this apart from STR. We'd need locks between
suspend and all io methods.

What's to be done?

	Regards
		Oliver

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel