Re: [patch]suspend support for usb serial

On Wed, May 02, 2007 at 11:53:49PM -0700, Greg KH wrote:
> On Fri, Apr 27, 2007 at 08:54:57PM +0200, Oliver Neukum wrote:
> > +EXPORT_SYMBOL(usb_serial_suspend);
> 
> I changed these to be EXPORT_SYMBOL_GPL() like the rest of the
> usb-serial core.
> 
> >  static const struct tty_operations serial_ops = {
> >  	.open =			serial_open,
> >  	.close =		serial_close,
> > @@ -1195,6 +1228,7 @@ static void fixup_generic(struct usb_ser
> >  	set_to_generic_if_null(device, read_bulk_callback);
> >  	set_to_generic_if_null(device, write_bulk_callback);
> >  	set_to_generic_if_null(device, shutdown);
> > +	set_to_generic_if_null(device, resume);
> 
> I don't think this is safe.  So I changed the generic driver to set the
> resume callback, but the individual drivers are going to have to set it
> on their own if they want to use the generic one.  It's just not safe to
> assume that all usb-serial drivers want, or even use the fields that you
> are using in that function.

Oh, and because of that, you might want to respin your other suspend
autosuspend patches, so I'll not apply them for now :)

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel