Re: anchors and their use
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Novell |
| Message-ID | <[email protected]> |
Am Mittwoch, 16. Mai 2007 17:30 schrieb Alan Stern: > On Wed, 16 May 2007, Oliver Neukum wrote: > > > Hi Alan, list, > > > > here's the patch to introduce anchors for use with "fire-and-forget" > > techniques and a modification for the skeleton driver to use them. > > This should make implementing pre/post_reset and suspend/resume > > much easier. > > This won't build because you forgot to export usb_unanchor_urb(). %&$% (censored) I'll redo the patch. It seems like I diffed an old version. > You could make usb_init_anchor() non-inline. I'm not sure where > tradeoff lies, but you might be over the limit. I'll do test compilations. > I don't like the way you combined the error handling in usb-skeleton > with the anchor stuff. Better to keep the two things in separate > patches. Problems with the packaging or the code? > There's no need for the version of skel_draw_down() which acquires the > mutex. You use it only in skel_flush(), so you might as well acquire > the mutex in the caller. OK. Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel