Re: autosuspend for hid
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Organization | Novell |
| Message-ID | <[email protected]> |
Am Montag, 21. Mai 2007 17:49 schrieb Oliver Neukum: > > But this code runs whenever a process opens the device file. If the > > device is suspended at that time, there might not be a remote wakeup > > request pending. So you'd run into trouble unless you did an > > autoresume before calling hid_start_in(). > > Which trouble? Remote wakeup must be activated as it is requested > with a bumped pm count. If there's no wakeup, what's the point in > pumping data in? There won't be any data. Oh, I see. In fact, the hid_start_in() in hid_open() itself is mostly a nop. resume() will restart the queue. Unless the device is not suspended before the driver opens. In that case the buffers filled before the data pump can be started may be lost. OK, I'll move it under the lock. Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel