Re: [patch]Re: autosuspend for HID devices, take #2
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Thu, 24 May 2007, Greg KH wrote: > On Wed, May 23, 2007 at 06:25:36PM +0200, Oliver Neukum wrote: > > Am Mittwoch, 23. Mai 2007 17:42 schrieb Alan Stern: > > > On Wed, 23 May 2007, Oliver Neukum wrote: > > > > > > > That gives me an idea. > > > > Resumption of a device has to be done in task context. So if I allocate > > > > a private freezable work queue for HID resumption, the freezer would > > > > guard against illicit resumptions, wouldn't it? > > > > > > You can use the ksuspend_usb_wq workqueue. It already exists, is > > > freezable, and is used for suspending and resuming USB devices. > > > > This adds a clean accessor for the USB core pm workqueue. > > But what code is using it? I don't want to add an api call if no one > uses it... In fact there's a potential user in hcd.c:usb_hcd_resume_root_hub(). If there's to be an accessor, that routine should use it. Oliver, you should be careful about what happens when CONFIG_PM is off. Under those conditions the workqueue is not created. Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel