Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()
Pete Zaitcev <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.kernel |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On Wed, 30 May 2007 10:47:52 +0200, Matthias Kaehlcke <[email protected]> wrote: > @@ -1608,8 +1605,7 @@ static void ub_reset_task(struct work_struct *work) > spin_lock_irqsave(sc->lock, flags); > sc->reset = 0; > tasklet_schedule(&sc->tasklet); > - list_for_each(p, &sc->luns) { > - lun = list_entry(p, struct ub_lun, link); > + list_for_each_entry(lun, &sc->luns, link) { > blk_start_queue(lun->disk->queue); > } > wake_up(&sc->reset_wait); This patch straddles the border of acceptable. The pointless obfuscation is balanced against the removal of explicit type in list_entry() and thus a possible mismatched struct. I'm not acking nor naking this. -- Pete ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel