Re: [PATCH 1/6] USB: remove __usb_port_suspend
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Wed, 30 May 2007, David Brownell wrote: > > According to the original code, plugging a non-targeted device into > > a non-OTG port would cause the host to initiate HNP on the OTG port! > > At least, that's what it looks like to me. Have I got it wrong? > > Yeah, I thought I noticed that too. It should just suspend the port > being enumerated. I haven't yet seen systems where that could be > an issue, but I think some of the Freescale parts could trigger that > bug when they start to support OTG. Not all the OTG boards which have > multiple host ports actually wire them out! > > The intent is: if a non-targeted device is plugged in, the only way > that connection may survive is if that device performs HNP and finds > that this one (in A_PERIPHERAL mode) is in *its* targeted peripheral > list. Otherwise, all ports should just act the same. Okay. I'll take out the part of the patch which changes is_targeted() and leave the rest as is. That should answer your objection and fix the problem about doing HNP on the wrong port, both. Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel