Re: [PATCH] drivers/block/ub.c: use list_for_each_entry()

 > The negative is the sheer number of helper functions in list.h. Personally,
 > I find it difficult to retain a working knowledge of them. Iterators are
 > particularly nasty that way. I'm thinking about dropping all of these
 > list_for_each_with_murky_argument_requirements_and_odd_side_effects()
 > and use plain for(;;), as a courtesy to someone who has to read the
 > code years down the road.

I think I disagree with this reasoning.  If I'm reading your code and
I see, say, list_for_each_entry_safe(), I can be pretty confident that
your loop works correctly.  If you write your own for loop, then I
have to check that you actually got the linked list walking right.

 - R.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel