Re: [PATCH] OHCI: Fix machine check in ohci_hub_status_data

On Fri, 2007-04-20 at 11:33 -0400, Alan Stern wrote:
> This patch (as901) fixes an oversight in ohci-hcd.  The
> hub_status_data routine must not try to access the controller's
> memory-mapped registers if the controller is in a low-power state;
> such attempts will cause a crash on some architectures (such as PPC).

What ever happened to this? It doesn't *seem* to be in the current tree,
or am I missing something?

> Signed-off-by: Alan Stern <[email protected]>
> 
> ---
> 
> Index: usb-2.6/drivers/usb/host/ohci-hub.c
> ===================================================================
> --- usb-2.6.orig/drivers/usb/host/ohci-hub.c
> +++ usb-2.6/drivers/usb/host/ohci-hub.c
> @@ -417,6 +417,8 @@ ohci_hub_status_data (struct usb_hcd *hc
>  	unsigned long	flags;
>  
>  	spin_lock_irqsave (&ohci->lock, flags);
> +	if (!test_bit(HCD_FLAG_HW_ACCESSIBLE, &hcd->flags))
> +		goto done;
>  
>  	/* undocumented erratum seen on at least rev D */
>  	if ((ohci->flags & OHCI_QUIRK_AMD756)
> 
>

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Comment: Johannes Berg (powerbook)

iD8DBQBGab15/ETPhpq3jKURAnV4AJ44V+FF6EQN03YZ1ikev7DK6k2+MwCgq5bb
2TpJmHnFMUShKGdg5MeQk1g=
=DjW3
-----END PGP SIGNATURE-----