Re: [PATCH 6/6] [C67x00] Merge c67x00-hub.c into c67x00-hcd.c
Peter Korsgaard <[email protected]>
| Newsgroups | gmane.linux.usb.devel,gmane.linux.ports.ppc.embedded |
|---|---|
| Message-ID | <[email protected]> |
>>>>> "Grant" == Grant Likely <[email protected]> writes: Hi, Grant> Rather than c67x00-hub.c being compiled seperately, the Grant> original code had c67x00-hub.c *included* by c67x00-hcd.c. Grant> This is a very bad idea. Simplest solution is to merge the Grant> two files into one and be done with it. Yeah, it isn't exactly pretty, but it's what the other hcd drivers do, E.G.: % grep -rs "include.*hub.c" *c ehci-hcd.c:#include "ehci-hub.c" ohci-hcd.c:#include "ohci-hub.c" uhci-hcd.c:#include "uhci-hub.c" I don't quite know why they do it like that though .. -- Bye, Peter Korsgaard ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel