Re: [PATCH] USB: driver for CM109 chipset
"Alfred E. Heggestad" <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Oliver Neukum wrote: > Am Sonntag, 10. Juni 2007 schrieb Alfred E. Heggestad: >> From: Alfred E. Heggestad <[email protected]> >> >> This driver adds support for USB VoIP phones using the CM109 chipset, >> such as the KIP-1000. Keypad is scanned and events are reported to >> the input subsystem. The buzzer can be activated by sending SND_TONE >> or SND_BELL to the input device. >> The driver has been tested with linux 2.6.21.3 on i386 and AMD64, >> and linux 2.6.21.1 on Broadcom BCM3302 (MIPS, OpenWRT Project) >> More testing and code review is welcome.. >> >> Signed-off-by: Alfred E. Heggestad <[email protected]> >> >> --- >> > <snap> > + > + ret = usb_submit_urb(dev->urb_ctl, GFP_KERNEL); > > Must be GFP_ATOMIC > Oliver, many thanks for your comments. I have update the code and I am about to send a new patch. I noticed that in the git repos of 2.6.22-rc4, the path to USB input drivers have changed from "drivers/usb/input" to "drivers/input/misc". should I also make this change before submitting the patch? /alfred > Regards > Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel