Re: [PATCH] Don't autosuspend Blackberry devices.

Am Mittwoch, 20. Juni 2007 schrieb Jeremy Katz:
> On Wed, 2007-06-20 at 00:12 +0200, Oliver Neukum wrote:
> > Am Dienstag, 19. Juni 2007 schrieb Jeremy Katz:
> > > Blackberry devices charge over USB.  By autosuspending the port, they are
> > > not able to charge reliably.
> > 
> > We made autosuspend configurable on a per device basis through
> > sysfs precisely for such cases. The blacklist is only for devices which
> > crash when they are suspended. This patch is not a good idea.
> 
> But this basically means that either
> a) users have to know that they need to twiddle a bit, or they get "my
> device doesn't work"
> or
> b) distros have to maintain a list of "these devices need to have the
> bit twiddled".  Which either ends up being done not at all, on a per
> distro basis or based on having to have yet another callout whenever a
> device is loaded.

We have udev running usually. A callout always happens when a USB
device is attached. Therefore that list should live in udev, not the kernel.

> As opposed to having the patch, in which case things work for the user
> as they are going to expect.

No, this patch will prevent laptops from using runtime power management
at all times, while a user space solution gives full control over when the
device should be charged or not be charged. Whether the laptop's or the
blackberry's battery should be conserved is not a decision the kernel
can make.

	Regards
		Oliver



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel