Re: [PATCH] Printer Gadget Driver v0.2.0 (kernel 2.6.21.3)
Greg KH <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 11, 2007 at 05:52:59PM -0400, Craig W. Nadler wrote: > From: Craig W. Nadler <[email protected]> > > G_PRINTER: Adds a USB printer gadget driver for use in printer firmware. > > This patch adds a USB printer gadget driver for use in printer firmware. The > printer gadget channels data between the USB host and a userspace program > driving the print engine. The user space program reads and writes the device > file /dev/g_printer to receive or send printer data. It can use ioctl calls > to the device file to get or set printer status. Can you run this through the scripts/checkpatch.pl script that is in the kernel tree now and fix all of the warnings that it produces? Also, one minor note: > +License and Disclaimer > +---------------------- > +This program is free software; you can redistribute it and/or > +modify it under the terms of the GNU General Public License as > +published by the Free Software Foundation; either version 2 of > +the License, or (at your option) any later version. Are you sure about the "any later version" part? You also don't need the license in the documentation file. thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel