Re: [PATCH] Active Huawei E220 devs

linlei 60022748 wrote:
> Hi there,
> This patch make the HUAWEI E220 device to map out three ports instead of only one virtural cd port.
> See the patch for the full explanation, CC's, and sign-off. And please apply.

Short of Greg's point that the return status of usb_control_msg() isn't
checked, the patch looks good to me. Or, more specifically, I'm signing off
on the unusual_devs.h portion of it.

So when ya'll send an updated version, I'll add my Signed-off-by.

-- 
Phil Dibowitz                             [email protected]
Open Source software and tech docs        Insanity Palace of Metallica
http://www.phildev.net/                   http://www.ipom.com/

"Never write it in C if you can do it in 'awk';
 Never do it in 'awk' if 'sed' can handle it;
 Never use 'sed' when 'tr' can do the job;
 Never invoke 'tr' when 'cat' is sufficient;
 Avoid using 'cat' whenever possible" -- Taylor's Laws of Programming

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGgKr0N5XoxaHnMrsRAn9GAKCUNF3q2v/QHyd+rIhkcE6SYgIwDwCbBNXy
ad6jfnH6nwIDWUCh3xdTpGg=
=Dt+H
-----END PGP SIGNATURE-----