Re: [PATCH] dm9601: HW header size shouldn't be included in packet length

On Tuesday 26 June 2007, Peter Korsgaard wrote:
> The dm9601 driver was including the 2 byte hardware header in the
> packet length, causing the HW to send 2 extra bytes of garbage on tx.
> 
> Signed-off-by: Peter Korsgaard <[email protected]>
> 
> ---
>  drivers/net/usb/dm9601.c |    5 +++--

This should go to netdev, not the usb list...

>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Index: linux-2.6.22-rc6/drivers/net/usb/dm9601.c
> ===================================================================
> --- linux-2.6.22-rc6.orig/drivers/net/usb/dm9601.c
> +++ linux-2.6.22-rc6/drivers/net/usb/dm9601.c
> @@ -489,6 +489,8 @@
>  	   b3..n: packet data
>  	*/
>  
> +	len = skb->len;
> +
>  	if (skb_headroom(skb) < DM_TX_OVERHEAD) {
>  		struct sk_buff *skb2;
>  
> @@ -501,10 +503,9 @@
>  
>  	__skb_push(skb, DM_TX_OVERHEAD);
>  
> -	len = skb->len;
>  	/* usbnet adds padding if length is a multiple of packet size
>  	   if so, adjust length value in header */
> -	if ((len % dev->maxpacket) == 0)
> +	if ((skb->len % dev->maxpacket) == 0)
>  		len++;
>  
>  	skb->data[0] = len;
> 
> -- 
> Bye, Peter Korsgaard
> 



-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel