Re: patch to shift memory allocations to usb_alloc_urb()
Oliver Neukum <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
Am Freitag, 29. Juni 2007 schrieb Greg KH: > On Fri, Jun 29, 2007 at 09:26:33AM -0400, Alan Stern wrote: > > On Fri, 29 Jun 2007, Oliver Neukum wrote: > > > > > Hi, > > > > > > this proved harder than it looks like. I can use cdc-acm over ohci with > > > this patch. So what do you think? > > > > It tries to do an awful lot all at once. A good place to start would > > be to use separate allocation for the Iso packet structures. This > > could be a simple standalone change. > > Yes please do that, I am tired of doing usb_alloc_urb(0,...) all over > the place for the majority of usb drivers. Allocating iso structures > should just be a separate function for those small number of drivers > that need those types of packets. > > And, as a plus, it let's us break the api again :) I am very reluctant to do that. It makes preallocating the tds impossible. If anything, we should split apart the allocator into 4 functions, one for each type of URB. Regards Oliver ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel