Re: patch to shift memory allocations to usb_alloc_urb()
David Brownell <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
> > Gaak. Just pass the usb_host_endpoint pointer in, with the relevant > > length indicator. Four functions would be ugly, unclean, unneceesary. > > All the relevant data is in the endpoint descriptor, which is stored > > in the host_endpoint struct. > > This would be true, were it not for those drivers which use interrupt URBs > on bulk endpoints. It's still true. You should never make such oddball exceptions into a special case around which an API is defined ... they should stay oddball exceptions. Like in this case, patching up the URB after it's set up would suffice. (And look sufficiently ugly that driver writers couldn't excuse themselves by "I didn't know I was not supposed to do that.) - Dave ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel