Re: [PATCH 2/2] usb-storage: implement autosuspend
Alan Stern <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Mon, 9 Jul 2007, Oliver Neukum wrote: > Am Freitag, 6. Juli 2007 schrieb Alan Stern: > > @@ -1028,6 +1039,7 @@ static int storage_probe(struct usb_inte > > * start it up. */ > > scsi_host_get(us_to_host(us)); > > atomic_inc(&total_threads); > > + usb_autopm_get_interface(intf); /* dropped in the scanning thread */ > > wake_up_process(th); > > > > return 0; > > It seems to me that we should fail probe() if usb_autopm_get_interface() > fails here. Other than that I obviously like it. It's impossible for usb_autopm_get_interface() to fail here, because it's part of a probe function. usbcore always resumes a device before doing a probe. It might not hurt to add a comment explaining this... Alan Stern ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel