Re: New driver proposal: iuu_phoenix patch formatted and indepedent file for external compilation

I will prepare a new patch including some improvements..

And Yes ! of course I'm pretty sure about "any later version" :-) !

Alain

-----Message d'origine-----
De : [email protected]
[mailto:[email protected]] De la part de Greg KH
Envoyé : mercredi 18 juillet 2007 10:41
À : Alain Degreffe
Cc : [email protected]
Objet : Re: [linux-usb-devel] New driver proposal: iuu_phoenix patch
formatted and indepedent file for external compilation

On Sat, Jul 14, 2007 at 11:54:09PM +0200, Alain Degreffe wrote:
> Submitted for review and comment.
> + *	This program is free software; you can redistribute it and/or modify
> + *	it under the terms of the GNU General Public License as published by
> + *	the Free Software Foundation; either version 2 of the License, or
> + *	(at your option) any later version.

Are you sure about "any later version"?  Just have to ask these days :)

> +static int
> +iuu_tiocmset(struct usb_serial_port *port, struct file *file, unsigned
int
> set,

Ick, your email client line wrapped the patch, care to resend it?

You also need a Signed-off-by: line as per the
Documentation/SubmittingPatches file states if you wish to have this
applied to the kernel tree.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel