Re: Kingsun KS-959 USB IrDA dongle - release candidate for submission (try 1)
Pete Zaitcev <[email protected]>
| Newsgroups | gmane.linux.irda.general,gmane.linux.usb.devel |
|---|---|
| Organization | Red Hat, Inc. |
| Message-ID | <[email protected]> |
On Sat, 21 Jul 2007 02:21:55 +0300, Samuel Ortiz <[email protected]> wrote: > > +/* Callback transmission routine */ > > +static void ks959_speed_irq(struct urb *urb) > > +{ > > + /* unlink, shutdown, unplug, other nasties */ > > + if (urb->status != 0) { > > + err("ks959_speed_irq: urb asynchronously failed - %d", urb->status); > > Here, shouldn't we call unlink_urb() if depending on the status value > (in the -EINPROGRESS at least) ? If a CPU is executing a callback, the URB is unlinked by definition. So, I see no opportunity to invoke unlink_urb _here_ as you said. -- Pete ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/