Re: "SERIAL_SAFE" versus "SAFE_SERIAL"
Greg KH <[email protected]>
| Newsgroups | gmane.linux.usb.devel |
|---|---|
| Message-ID | <[email protected]> |
On Sun, Jul 29, 2007 at 05:31:12PM -0400, Robert P. J. Day wrote: > > i think someone higher up the food chain might want to handle what > appear to be typoes here: > > $ grep -r SAFE_SERIAL * > drivers/usb/serial/safe_serial.c:#if defined(CONFIG_USBD_SAFE_SERIAL_VENDOR) && !defined(CONFIG_USBD_SAFE_SERIAL_PRODUCT) > drivers/usb/serial/safe_serial.c:#error "SAFE_SERIAL_VENDOR defined without SAFE_SERIAL_PRODUCT" > drivers/usb/serial/safe_serial.c:#if ! defined(CONFIG_USBD_SAFE_SERIAL_VENDOR) > drivers/usb/serial/safe_serial.c:#if defined(CONFIG_USB_SAFE_SERIAL_VENDOR) > drivers/usb/serial/safe_serial.c: (CONFIG_USB_SAFE_SERIAL_VENDOR, CONFIG_USB_SAFE_SERIAL_PRODUCT, CDC_DEVICE_CLASS, > > $ grep -r SERIAL_SAFE * > ... lots of defconfig's deleted ... > drivers/usb/serial/Makefile:obj-$(CONFIG_USB_SERIAL_SAFE) += safe_serial.o > drivers/usb/serial/Kconfig:config USB_SERIAL_SAFE > drivers/usb/serial/Kconfig:config USB_SERIAL_SAFE_PADDED > drivers/usb/serial/Kconfig: depends on USB_SERIAL_SAFE > > i mean, is it *deliberate* to mix both "USB_SAFE_SERIAL" and > "USB_SERIAL_SAFE" as above? yeesh. No, they should all be uniform, please make them so. thanks, greg k-h ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ [email protected] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel