Re: usbserial, io_edgeport: Remove CmdUrbs

On Mon, Jul 30, 2007 at 02:00:25PM -0700, Pete Zaitcev wrote:
> On Mon, 30 Jul 2007 13:07:02 -0700, Greg KH <[email protected]> wrote:
> > On Mon, Jul 30, 2007 at 12:58:57PM -0700, Pete Zaitcev wrote:
> 
> > > Oliver converted CmdUrbs into an atomic with commit
> > > 96c706ed1c46470598d785124b2a7fb233b27dab .
> > > It seems like a waste to do for a long forgotten debugging aid.
> > > Let's just remove it altogether.
> > 
> > Nah, as someone who has had to debug this driver, years later from when
> > I wrote it (I started the thing back in 1999), I'd prefer to leave this.
> > I has come in handy at times, and isn't causing any performance or
> > memory issues by leaving it there.
> 
> If I were doing it, I'd drop all dbg's... But all right, if that's
> how you like your code, I should respect that. What about bitfields though,
> may I at least kill those? I've got a co-worker to provide me a shell
> access for testing of that.

Sure, if you think it's better that there are not bitfields there, feel
free to send me a patch.

thanks,

greg k-h

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel