Re: [patch 2/8] NIKON D50 is an unusual device

On Fri, 10 Aug 2007 [email protected] wrote:

> From: Milinevsky Dmitry <[email protected]>
> 
> This short patch allows NIKON D50 to be mounted as UMS[unusual device]
> on Linux niam 2.6.22-rc7-cfs-v18 #2 PREEMPT Tue Jul 3 22:35:53 EEST
> 2007 i686 Intel(R) Celeron(R) M processor 1.50GHz GenuineIntel
> GNU/Linux,
> some previous kernels...

> diff -puN drivers/usb/storage/unusual_devs.h~nikon-d50-is-an-unusual-device drivers/usb/storage/unusual_devs.h
> --- a/drivers/usb/storage/unusual_devs.h~nikon-d50-is-an-unusual-device
> +++ a/drivers/usb/storage/unusual_devs.h
> @@ -327,6 +327,13 @@ UNUSUAL_DEV(  0x04b0, 0x0409, 0x0100, 0x
>  		US_SC_DEVICE, US_PR_DEVICE, NULL,
>  		US_FL_FIX_CAPACITY),
>  
> +/* Reported by Milinevsky Dmitry <[email protected]> */
> +UNUSUAL_DEV(  0x04b0, 0x0409, 0x0100, 0x0100,
> +		"NIKON",
> +		"NIKON DSC D50",
> +		US_SC_DEVICE, US_PR_DEVICE, NULL,
> +		US_FL_FIX_CAPACITY),
> +
>  /* Reported by Andreas Bockhold <[email protected]> */
>  UNUSUAL_DEV(  0x04b0, 0x0405, 0x0100, 0x0100,
>  		"NIKON",

If I'm reading this correctly, the patch adds a duplicate entry.  And
the two entries aren't even in the right place since 0x0409 should
come after 0x0405, not before.

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel