Re: [PATCH] USB: SisUSB2VGA: Lindent drivers/usb/misc/sisusbvga/sisusb_struct.h

Hi,

On 8/10/07, David Brownell <[email protected]> wrote:
> On Friday 10 August 2007, Felipe Balbi wrote:
>
> >Better indentation
>
> I don't think so.  This whole patch seems to make one
> type of change:
>
>
> > -unsigned charSt_ModeID;
> > -unsigned shortSt_ModeFlag;
> > -unsigned charSt_StTableIndex;
> > -unsigned charSt_CRT2CRTC;
> > -unsigned charSt_ResInfo;
> > -unsigned charVB_StTVFlickerIndex;
> > -unsigned charVB_StTVEdgeIndex;
> > -unsigned charVB_StTVYFilterIndex;
> > -unsigned charSt_PDC;
>
> ... all neatly indented so the fields line up.
>
> TheProblemISeeWithThatCodeIsThatItUsesCamelCase.

Yeah, get rid of the CaMeLcAsE is in my TODO list for this driver...
I'll re-factor this patch and apply the get rid of CamelCase to the
other files...

>
>
> > +unsigned char St_ModeID;
> > +unsigned short St_ModeFlag;
> > +unsigned char St_StTableIndex;
> > +unsigned char St_CRT2CRTC;
> > +unsigned char St_ResInfo;
> > +unsigned char VB_StTVFlickerIndex;
> > +unsigned char VB_StTVEdgeIndex;
> > +unsigned char VB_StTVYFilterIndex;
> > +unsigned char St_PDC;
>
> ... the fields stopped lining up.
>
> In that particular stretch it's not all that much worse, although
> it does seem harder to find the member names.  However, overall
> I couldn't agree this is an improvement.
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> [email protected]
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
>


-- 
Best Regards,

Felipe Balbi
[email protected]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel