Re: USB-related oops in sysfs with linux v2.6.23-rc3-50-g28e8351

Cornelia Huck wrote:
> On Wed, 15 Aug 2007 23:54:43 +0900,
> Tejun Heo <[email protected]> wrote:
> 
>> Alan Stern wrote:
>>> I think we can simply remove the error message.  There's no obvious 
>>> reason why sysfs_remove_bin_file() should complain about attempts to 
>>> remove a nonexistent file; sysfs_remove_file() doesn't.
>>>
>>> This patch will get rid of the annoying error messages.  It won't do 
>>> anything about your keyboard's tendency to spontaneously stop working, 
>>> alas.
>> Agreed but I think sysfs_remove_bin_file() should relay the return value
>> from sysfs_has_and_remove() to the caller.
> 
> Three comments:
> 
> - Randy made sysfs_remove_bin_file() return void in commit
> 995982ca79d9262869513948ec7c540f32035491.
> 
> - For symmetry reasons, sysfs_remove_file() should then also pass the
> return value on.
> 
> - I'm not sure who wants to care whether they removed an existing or
> non-existing file. But maybe I'm just unimaginative.

Hmmm... Well, failure information is lost there, so I was a bit worried.
 It probably doesn't really matter and can be easily changed later if
needed.  If sysfs_remove_file() returns void, I have no objection.

Thanks.

-- 
tejun

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel