Re: DMA problem in net2280?

Alan Stern <[email protected]>
Newsgroups gmane.linux.usb.devel
Message-ID <[email protected]>
On Fri, 17 Aug 2007, David Brownell wrote:

> On Friday 17 August 2007, Alan Stern wrote:
> 
> > I tracked it down; there was a bug in the g_file_storage part of your
> > remove_usb_ep_*_buffer patch.  You must not have tested it.
> > 
> > A patch to fix it follows.
>  
> Whoops, my bad.  Sorry.
> 
> Though why you were changing those dma addresses in the first place
> is a bit of a puzzle; shouldn't have been needed.

They weren't being changed; they were being initialized.  The driver 
uses two requests per buffer (one IN and one OUT).  Only one request's
DMA pointer could be initialized by the old usb_ep_alloc_buffer() call, 
so the other had to be set by hand.  You got changed the call to 
kmalloc() but didn't remove the second initialization.

Alan Stern


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.